Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove abandoned description on README #222

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

JohnTitor
Copy link
Member

Closes #221

@0xpr03
Copy link
Member

0xpr03 commented Oct 1, 2019

We also may want to remove the sponsoring button. CC @passcod

@Dylan-DPC-zz
Copy link

I think we have enough maintainers on the team already that we don't need to state in the readme. We can leave the issue open if you want in case anyone else pops up in future.

Also +1 on the sponsorship if passcod is fine with it, don't want to end up having to face the "who get's sponsored?" question

@JohnTitor
Copy link
Member Author

Remove description for looking for maintainers.
If @passcod wants to remove the sponsor button, I'd like to submit another PR.

@passcod
Copy link
Member

passcod commented Oct 1, 2019

Yes absolutely remove it. I really should have done so upon committing the notice, it was ambiguous/irresponsible in hindsight to leave it

@passcod
Copy link
Member

passcod commented Oct 1, 2019

Also the changelog should mark the organisational change from me to y'all

@JohnTitor
Copy link
Member Author

Should we do it with this pull request or another pull request?

@dhiemaz
Copy link

dhiemaz commented Oct 1, 2019

I think this PR is about to remove abandoned description, so for removing maintainers should do with another PR. wdyt @passcod, @Dylan-DPC

@passcod
Copy link
Member

passcod commented Oct 1, 2019

I don't mind either way, but new PR would free this one to land without more delay I think

@JohnTitor
Copy link
Member Author

So, could we merge this now?

@Dylan-DPC-zz
Copy link

Yes. Let's merge this. Otherwise someone would come up with another change and we'll be stuck for a long time 😂

@JohnTitor JohnTitor merged commit ceb22d7 into notify-rs:main Oct 1, 2019
@JohnTitor JohnTitor deleted the update-readme branch October 1, 2019 21:12
atouchet pushed a commit to atouchet/notify that referenced this pull request Nov 23, 2019
JohnTitor added a commit that referenced this pull request Jan 2, 2020
* Dependencies: Update winapi and remove kernel32-sys (#217)

This removes the dependency on kernel32-sys, replacing the kernel32-sys calls with the appropriate winapi calls.

* Remove abandoned description on README (#222)

* Update info and bump to 4.0.15

* Fixup winapi

Co-authored-by: Wesley Norris <repnop@outlook.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README description of abandoned
5 participants